Address MattE feedback

CrayLabs · Mar 13, 2023 · 4cf84a7 · 4cf84a7
1 parent 8743372
commit 4cf84a7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/include/client.h b/include/client.h
@@ -1422,13 +1422,14 @@ class Client : public SRObject
         *  \param dataset The dataset which will receive the tensor
         *  \param name The name by which the tensor shall be added
         *              to the dataset
-        *   \param data Result of a get_tensor command containing tensor data
+        *   \param tensor_data get_tensor command reply containing
+        *                      tensor data
         *   \throw SmartRedis::Exception if addition of tensor fails
         */
        inline void _add_dataset_tensor(
             DataSet& dataset,
             const std::string& name,
-            CommandReply data);
+            CommandReply tensor_data);
 
         /*!
         *   \brief Retrieve the tensor from the DataSet and return

diff --git a/include/redis.h b/include/redis.h
@@ -549,7 +549,7 @@ class Redis : public RedisServer
 
         /*!
         *   \brief Pipeline execute a series of commands
-        *   \param cms The commands to execute
+        *   \param cmds The commands to execute
         *   \returns Pipeline reply from the command execution
         *   \throw SmartRedis::Exception if command execution fails
         */

diff --git a/src/cpp/client.cpp b/src/cpp/client.cpp
@@ -1667,12 +1667,12 @@ inline CommandReply Client::_get_dataset_metadata(const std::string& name)
 inline void Client::_add_dataset_tensor(
     DataSet& dataset,
     const std::string& name,
-    CommandReply data)
+    CommandReply tensor_data)
 {
     // Extract tensor properties from command reply
-    std::vector<size_t> reply_dims = GetTensorCommand::get_dims(data);
-    std::string_view blob = GetTensorCommand::get_data_blob(data);
-    SRTensorType type = GetTensorCommand::get_data_type(data);
+    std::vector<size_t> reply_dims = GetTensorCommand::get_dims(tensor_data);
+    std::string_view blob = GetTensorCommand::get_data_blob(tensor_data);
+    SRTensorType type = GetTensorCommand::get_data_type(tensor_data);
 
     // Add tensor to the dataset
     dataset._add_to_tensorpack(name, (void*)blob.data(), reply_dims,