Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease pinned pydantic version #51

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

AlyssaCote
Copy link
Collaborator

@AlyssaCote AlyssaCote commented Apr 22, 2024

This PR is decreases the pinned pydantic version from "pydantic>=2.5.2" to "pydantic>=1.10.14" to remain compatible with the other repos. model_dump() was changed to dict(), which is deprecated and will be removed by pydantic v3. field_validator was changed to validator, and is also deprecated and scheduled to be removed by v3 of pydantic.

@AlyssaCote AlyssaCote marked this pull request as draft April 22, 2024 20:04
@AlyssaCote AlyssaCote changed the title Decrease pydantic version Decrease pinned pydantic version Apr 22, 2024
@AlyssaCote AlyssaCote marked this pull request as ready for review April 22, 2024 20:17
@AlyssaCote AlyssaCote requested a review from ashao April 22, 2024 20:17
@AlyssaCote AlyssaCote self-assigned this Apr 23, 2024
@AlyssaCote AlyssaCote requested a review from MattToast April 23, 2024 18:27
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small sanity check but nothing worth holding up approval over! LGTM!!

@AlyssaCote AlyssaCote merged commit a2d7cb2 into CrayLabs:develop Apr 24, 2024
7 checks passed
@AlyssaCote AlyssaCote added area: build Issues related to build, makefiles, installs, etc repo: smartdashboard labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Issues related to build, makefiles, installs, etc repo: smartdashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants