Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version and allow backwards compatibility #40

Merged
merged 3 commits into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
author = 'Hewlett Packard Enterprise'

# The full version, including alpha/beta/rc tags
version = "0.0.2"
version = "0.0.3"

# The full version, including alpha/beta/rc tags
release = version
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "smartdashboard"
version = "0.0.2"
version = "0.0.3"
requires-python = ">=3.8,<3.11"
authors = [
{name = "CrayLabs: a Hewlett Packard Enterprise OSS Organization", email = "[email protected]"},
Expand All @@ -52,7 +52,7 @@ readme = "README.md"
dependencies = [
"pandas>=2.0.0",
"pydantic>=2.5.2",
"streamlit>=1.27.1",
"streamlit>=1.28.0",
"watchdog>=3.0.0",
]

Expand Down
4 changes: 2 additions & 2 deletions smartdashboard/schemas/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ class HasName(BaseModel):


class HasOutErrFiles(BaseModel):
out_file: str
err_file: str
out_file: str = ""
err_file: str = ""


class HasTelemetryMetaData(BaseModel):
Expand Down
2 changes: 1 addition & 1 deletion smartdashboard/static/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */

/* change font of expander label */
div[data-testid="stExpander"] div[role="button"] p {
div[data-testid="stExpander"] details summary p {
font-family: "Source Sans Pro", sans-serif;
font-weight: 600;
color: var(--primary-text-color);
Expand Down
4 changes: 2 additions & 2 deletions smartdashboard/utils/ManifestReader.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ def __init__(self, file_path: str) -> None:
"Version data is malformed.", file=self._file_path, exception=key
) from key

if version != "0.0.2":
if version not in ("0.0.2", "0.0.3"):
version_exception = Exception(
"SmartDashboard version 0.0.2 is unable to parse manifest "
"SmartDashboard version 0.0.3 is unable to parse manifest "
f"file at version {version}."
)
raise VersionIncompatibilityError(
Expand Down
2 changes: 1 addition & 1 deletion smartdashboard/view_builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def exp_builder(manifest: Manifest) -> ExperimentView:
st.write("Path: " + manifest.experiment.path)
st.write("Launcher: " + manifest.experiment.launcher)

with st.expander(label="Logs"):
with st.expander(label="Logs", expanded=True):
col1, col2 = st.columns([6, 6])
with col1:
st.write("Output")
Expand Down
3 changes: 1 addition & 2 deletions smartdashboard/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,7 @@ class ErrorView(ViewBase):
information.
"""

def update(self) -> None:
...
def update(self) -> None: ...


class OverviewView:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@
0,
Manifest,
),
pytest.param(
"tests/utils/manifest_files/0.0.2_manifest.json",
2,
4,
3,
3,
Manifest,
),
],
)
def test_get_manifest(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"json_file, result_type",
[
pytest.param("tests/utils/manifest_files/manifesttest.json", Manifest),
pytest.param("tests/utils/manifest_files/0.0.2_manifest.json", Manifest),
pytest.param("tests/utils/manifest_files/no_apps_manifest.json", Manifest),
pytest.param("file_doesn't_exist.json", ManifestError),
pytest.param("tests/utils/manifest_files/JSONDecodererror.json", ManifestError),
Expand Down
Loading
Loading