Pull updates to begin new project #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Triggers in o6s * update severity for last kiss target * Fix tabbed indents and fix missing square bracket * More indenting fixes
This allows users to specify shorter/longer outputs from triggers. Also, overriding conditions lets folks narrow (or broaden) when triggers show up, e.g. see provokes even when you're not a tank or turn off mechanics triggers for particular roles when they matter less. Style-wise the capitalization on all the options looks weird, but I'm just going to leave it for now for the sake of consistency. Closes #51.
Also shorten the names.
Releases page is now https only, so needs some extra flags and should use the correct url.
* Create fr.js New locale 'fr' * Update fr.js Added translation for Seal and Unseal.
These names come from ACT and not the game, so they're all in English.
The log doesn't get set up until after the plugin has started. There's no event for this, so defer cactbot initialization until the first slow timer. This allows initialization error messages to not be dropped on the floor.
resource-bar, timer-bar, and timer-icon all currently only allow flat text. Allow html entities in these text strings as well.
This is intended to help solve issue #57.
Triggers can now have localized regexes. For a given local (e.g. ko)
if there's a regexKo entry on the trigger, that will take precedence
over regex on its own.
Additionally, any trigger field that can be treated as a function
can now also return localized responses as an object, e.g.
instead of:
return 'Get Out';
...triggers can instead do something like:
return {en: 'Get Out', fr: 'something french here, etc'};
This change also avoids running Regexes.Parse on every single log line
for every single trigger. @_@;;
This will help issue #57.
This fixes a typo from 4dd1cc4, whoops.
This prevents Bootshine (35) from matching Hakaze (1D35).
Adding targetable/untargetable lines where appropriate
Add de.js (german lang)
Uri unescaping, oops. /o\ Fixes #90.
This is the way it used to work and allows folks working in git repositories that aren't inside of the ACT folder to have their user folder work as they'd expect. If the html-relative doesn't exist, it'll fall back to DLL-relative. Fixes #88.
JEDF clients should now work with timeline sync and triggers. timeline translation for german client added
Multi-line conditionals need {}.
Two space indent everywhere.
Line up }; with the { indent level.
See comments in #57 for more details.
Fixes #94.
This should help with issue #57.
Tracker regexes can have hyphens in them too.
The path to resize_handle.js Fixes #102.
If you've seen a mob die, then that's more accurate than a tracker time.
Previously you could only do this on named sounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.