Fix/updateRoute #90

Bouba-cassation · 2024-03-22T16:51:59Z

Issue description :

update documents route and put status done for automatic documents
adding prompt to ask you if you wanna run the script

Describe your changes :

I change updateRouteById
if (updatedDocument?.route == 'automatic') { await this.updateStatusById(_id, 'done'); }

How to test :

Make some changes in your storage folder, put an automatic code => in documents
"NACCode": "11A", "NPCode": "11A", "endCaseCode": "11A",

Checklist before requesting a review

I have performed a self-review of my code.
The feature works locally.
If it's relevant I added tests.
[] Will this be part of a product update? If yes, please write one phrase about this update.

ajeanneney · 2024-03-25T08:57:53Z

packages/courDeCassation/README.md

@@ -119,7 +119,7 @@ prod label script exportSpecificDocument --documentNumber=10000 --source=jurinet

 In Wallix, with a Cygwin terminal:
 ```
-prod label script updateRoute --status=free
+prod label script updateRouteForFreeDocuments --status=free


A l'occasion il faudra qu'on mette a jour/supprime ce readme qui n'est plus a jour 😆

Pas que le readme @ajeanneney

ajeanneney · 2024-03-25T09:02:55Z

packages/courDeCassation/src/connector/mapper/extractors/extractRoute/extractRoute.ts

@@ -27,6 +28,10 @@ function extractRoute(
  switch (source) {
    case 'jurinet':
      try {
+        logger.error({


Suggested change

logger.error({

logger.log({

c'est pas encore une erreur a ce niveau la ;)

C'est un logger qui doit être supprimer, j'ai du l'oublier

ajeanneney · 2024-03-25T09:04:45Z

packages/courDeCassation/src/connector/mapper/extractors/extractRoute/extractRoute.ts

@@ -27,6 +28,10 @@ function extractRoute(
  switch (source) {
    case 'jurinet':
      try {
+        logger.error({
+          operationName: 'extractRouteForJurinet',
+          msg: `${routeInfos}`,


"extractRouteForJurinet","msg":"[object Object]" ça log ça ducoup :/

docker container exec -it label_backend_1 sh -c "cd packages/courDeCassation; sh scripts/runLocalScript.sh ./dist/scripts/updateRoute.js" pour tester en local 😉

Et enfait mieux vaut ne pas logger les routeInfos, il y a les parties dedans (données sensibles)

ajeanneney · 2024-03-25T09:06:49Z

packages/courDeCassation/README.md

@@ -119,7 +119,7 @@ prod label script exportSpecificDocument --documentNumber=10000 --source=jurinet

 In Wallix, with a Cygwin terminal:
 ```
-prod label script updateRoute --status=free
+prod label script updateRouteForFreeDocuments --status=free


Suggested change

prod label script updateRouteForFreeDocuments --status=free

prod label script updateRouteForFreeDocuments

ajeanneney · 2024-03-25T09:08:02Z

packages/courDeCassation/src/scripts/updateRoute.ts

  });
+  const { environment, settings } = await parametersHandler.getParameters();
+  prompt.question(
+    'Confirmez vous le lancement de ce script (yes/no)? ',


Suggested change

'Confirmez vous le lancement de ce script (yes/no)? ',

'Voulez vous mettre a jour le circuit de relecture de tous les documents free (yes/no)? ',

Sinon bien vu le message de confirmation 🆗

ajeanneney · 2024-03-25T09:15:36Z

packages/courDeCassation/src/scripts/updateRoute.ts

@@ -59,20 +73,3 @@ async function updateRoute(status: documentType['status']) {
    );


Suggested change

);

);

if(newRoute === 'automatic'){

documentRepository.updateStatusById(documentsToUpdate[index]._id, "done");

}

Je pense que c'est mieux de mettre la logique ici :

ça évite d'avoir de la logique dans le repository

a cette endroit on est sur que le document est en status free car c'est défini en dur dans le code, le risque selon moi de le mettre dans le repository est que le updateStatusById soit appelé dans un autre contexte qui peut poser problème. Si un jour on appelle updateRouteById sur un document loaded et que sa nouvelle route est automatique alors il passe a done alors qu'il n'est pas annoté par le moteur

ajeanneney · 2024-03-25T09:17:35Z

packages/generic/backend/src/modules/document/repository/buildDocumentRepository.ts

@@ -216,6 +216,9 @@ const buildDocumentRepository = buildRepositoryBuilder<
    async updateRouteById(_id, route) {
      await collection.updateOne({ _id }, { $set: { route } });
      const updatedDocument = await collection.findOne({ _id });
+      if (updatedDocument?.route == 'automatic') {


je préfère qu'on ne mette pas la logique dans le repository, cf. commentaire plus haut

* Feature/appeal number 399 (#82) * adding regex to get registreNUmber || pourvoie * adding logique to extract RG or Appeal or NumeroRoleGeneral for title in label * renaming and resolving bug * renaming and resolving bug * rename and lint * optimisation of code * little clean * updating sder commit --------- Co-authored-by: Antoine Jeanneney <[email protected]> * Fix/updateRoute (#90) * updating status to done for automatic route decisions * updating readme * updating antoine's request --------- Co-authored-by: Antoine Jeanneney <[email protected]>

* updating status to done for automatic route decisions * updating readme * updating antoine's request

Bouba-cassation added 2 commits March 22, 2024 17:44

updating status to done for automatic route decisions

836d99b

updating readme

c75ea1f

Bouba-cassation requested a review from ajeanneney March 22, 2024 16:51

ajeanneney changed the title ~~Feature/extract route done~~ Fix/updateRoute Mar 25, 2024

ajeanneney reviewed Mar 25, 2024

View reviewed changes

updating antoine's request

2e70323

ajeanneney approved these changes Mar 25, 2024

View reviewed changes

Bouba-cassation merged commit e97412e into dev Mar 25, 2024
2 checks passed

ajeanneney deleted the feature/extractRouteDone branch March 25, 2024 13:28

s-diallo pushed a commit that referenced this pull request Oct 8, 2024

Fix/updateRoute (#90)

33e10f3

* updating status to done for automatic route decisions * updating readme * updating antoine's request

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/updateRoute #90

Fix/updateRoute #90

Bouba-cassation commented Mar 22, 2024

ajeanneney Mar 25, 2024

Bouba-cassation Mar 25, 2024

ajeanneney Mar 25, 2024

Bouba-cassation Mar 25, 2024 •

edited

Loading

ajeanneney Mar 25, 2024

ajeanneney Mar 25, 2024

ajeanneney Mar 25, 2024

ajeanneney Mar 25, 2024

ajeanneney Mar 25, 2024

	prod label script updateRouteForFreeDocuments --status=free
	prod label script updateRouteForFreeDocuments

	'Confirmez vous le lancement de ce script (yes/no)? ',
	'Voulez vous mettre a jour le circuit de relecture de tous les documents free (yes/no)? ',

		@@ -59,20 +73,3 @@ async function updateRoute(status: documentType['status']) {
		);

-    );
+    );
+    if(newRoute === 'automatic'){
+        documentRepository.updateStatusById(documentsToUpdate[index]._id, "done");
+    }

Fix/updateRoute #90

Fix/updateRoute #90

Conversation

Bouba-cassation commented Mar 22, 2024

Issue description :

Describe your changes :

How to test :

Checklist before requesting a review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bouba-cassation Mar 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bouba-cassation Mar 25, 2024 •

edited

Loading