change clean duplication logic #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajeanneney
commented
Dec 9, 2024
ajeanneney
commented
- considérer qu'une décision est identique en fonction de son externalId (pareil que sourceId+sourceName mais plus simple)
- Ne pas prendre en compte les documents rejected (est-ce qu'il faudra les supprimer un jour ?)
- le seul critère qui subsite pour savoir quel document on conserve est la dateCreation, on conserve le document le plus récent
| const documents = await documentRepository.findAll(); | ||
| const sortedDocuments = documents.sort(compareDocumentsByStatus); | ||
| const documents = (await documentRepository.findAll()).filter( | ||
| (doc) => doc.status !== 'rejected', |
There was a problem hiding this comment.
Note: j'ai vu que le script cleanDuplicatedDocuments se lancer aussi au moment de l'exportRejectedDocument... à supprimer comme convenu avec toi.
Bouba-cassation
approved these changes
Dec 10, 2024
Bouba-cassation
added a commit
that referenced
this pull request
Jan 16, 2025
* Add zoning to seed TJ documents (#153) * format seed json * add zoning for tj documents --------- Co-authored-by: Antoine Jeanneney <[email protected]> * change clean duplication logic (#152) Co-authored-by: Antoine Jeanneney <[email protected]> * feat: fakeData refresh date (#156) * fix: refreshDate (#157) * fetch TCOM decisions (#155) Co-authored-by: Antoine Jeanneney <[email protected]> --------- Co-authored-by: Antoine Jeanneney <[email protected]> Co-authored-by: Antoine Jeanneney <[email protected]> Co-authored-by: juliengrach-cassation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.