Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After analyzing the code as part of updating this doc I found a few spots that might have some problems. I've written them down in this issue: CounterpartyXCP/counterparty-core#2601
Additionally I think that we are perhaps missing some test cases. I wrote down all the cases I could think of in an issue here: CounterpartyXCP/counterparty-core#2602
I checked off the ones that I know for sure already exists. The vectors are pretty easy to know what they are doing but it's very difficult to understand what the scenario tests do. So many more of the test cases might already be "checked off".
I also came up with a list of questions that I think would be great if we could discuss them here on this PR. Thanks!
Fairminter.burn_payment
default toTrue
?Fariminter.premint_quantity
hard cap checks be>
instead of>=
?Fairminter.soft_cap
be allowed to equalFairminter.hard_cap
?