Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fair Minting Spec #218

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

warrenpuffett
Copy link
Contributor

@warrenpuffett warrenpuffett commented Oct 26, 2024

After analyzing the code as part of updating this doc I found a few spots that might have some problems. I've written them down in this issue: CounterpartyXCP/counterparty-core#2601

Additionally I think that we are perhaps missing some test cases. I wrote down all the cases I could think of in an issue here: CounterpartyXCP/counterparty-core#2602
I checked off the ones that I know for sure already exists. The vectors are pretty easy to know what they are doing but it's very difficult to understand what the scenario tests do. So many more of the test cases might already be "checked off".

I also came up with a list of questions that I think would be great if we could discuss them here on this PR. Thanks!

  • Should Fairminter.burn_payment default to True?
  • Should Fariminter.premint_quantity hard cap checks be > instead of >=?
  • Should Fairminter.soft_cap be allowed to equal Fairminter.hard_cap?

@ouziel-slama
Copy link
Contributor

@warrenpuffett @adamkrellenstein sorry I totally missed thisPR!!

LGTM than you very much!

  • Should Fairminter.burn_payment default to True?

IMO no but it's a political decision :-)

  • Should Fariminter.premint_quantity hard cap checks be > instead of >=?
  • Should Fairminter.soft_cap be allowed to equal Fairminter.hard_cap?

hum.. indeed there is no good reason to prohibit that premint_quantity or soft_cap is equal to hard_cap.
However, it is a protocol change that requires caution and not urgency. I opened an issue: CounterpartyXCP/counterparty-core#2686

@ouziel-slama
Copy link
Contributor

Just added a little note:

asset and asset_parent must respect the named asset format

@adamkrellenstein adamkrellenstein merged commit ebe7b96 into master Nov 11, 2024
@adamkrellenstein adamkrellenstein deleted the wp/fair-minting-spec-update branch November 11, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants