Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract Address Length #132

Closed
the-frey opened this issue Dec 17, 2021 · 4 comments
Closed

Contract Address Length #132

the-frey opened this issue Dec 17, 2021 · 4 comments
Labels
bug Something isn't working
Milestone
v2.1.0

Comments

@the-frey
Copy link
Contributor

It is shorter since v2.0.3 -> we need to increase in order to be forwards compatible with mainline.

Terse ticket for now. Let's discuss fix and upgrade path.

cc @dimiandre @JakeHartnell @faddat @giansalex
@the-frey the-frey added the bug Something isn't working label Dec 17, 2021
@the-frey
Copy link
Contributor Author

See CosmWasm/wasmd#685 (comment)

@the-frey the-frey added this to the v2.1.0 milestone Dec 17, 2021
@giansalex
Copy link
Member

v1.0.0-juno | v1.0.0-juno3
image

https://github.com/notional-labs/wasmd/blob/v1.0.0-juno3/x/wasm/keeper/keeper.go#L880

@the-frey
Copy link
Contributor Author

the-frey commented Dec 17, 2021 •
edited
Loading

So in terms of an upgrade path - we need to write a migration that:

  • Looks up all contracts currently instantiated
  • Replaces their contract addr with a 32 byte version

That right?

Luckily not many contracts deployed yet 🤔

JakeHartnell added a commit to JakeHartnell/wasmd that referenced this issue Dec 17, 2021
@JakeHartnell
Fix address length, credit @giansalex
d843a1b 
CosmosContracts/juno#132 (comment)
@JakeHartnell JakeHartnell mentioned this issue Dec 17, 2021
Closed
@the-frey the-frey mentioned this issue Dec 19, 2021
Merged
@the-frey
Copy link
Contributor Author

fixed in wasmd and upgraded in #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
2 participants
@the-frey @giansalex