Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ica with demo controller #848

Merged
merged 2 commits into from
May 10, 2022
Merged

Ica with demo controller #848

merged 2 commits into from
May 10, 2022

Conversation

ethanfrey
Copy link
Member

Full implementation of an ICA controller. Thanks to IBC team.

Replaces #839

@ethanfrey ethanfrey requested a review from alpe as a code owner May 9, 2022 14:04
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #848 (db195f6) into main (5233ed7) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   58.72%   58.92%   +0.19%     
==========================================
  Files          52       52              
  Lines        6140     6165      +25     
==========================================
+ Hits         3606     3633      +27     
+ Misses       2266     2265       -1     
+ Partials      268      267       -1     
Impacted Files Coverage Δ
app/app.go 88.93% <100.00%> (+0.63%) ⬆️
x/wasm/keeper/keeper.go 88.23% <0.00%> (+0.34%) ⬆️

@ethanfrey ethanfrey force-pushed the ica-with-demo-controller branch from 2e545da to 91d729d Compare May 9, 2022 15:01
@ethanfrey
Copy link
Member Author

@alpe this is much easier, as this built/tested/maintained in another repo.

Integration was based on https://github.com/cosmos/interchain-accounts-demo/blob/v0.1.0/app/app.go

@ethanfrey ethanfrey added this to the v0.27.0 milestone May 9, 2022
@ethanfrey ethanfrey force-pushed the ica-with-demo-controller branch from 91d729d to db195f6 Compare May 9, 2022 19:40
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice!
disclaimer: I have looked at integration for app.go but not into intertx details

@ethanfrey ethanfrey merged commit d671a69 into main May 10, 2022
@ethanfrey ethanfrey deleted the ica-with-demo-controller branch May 10, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants