Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate testdata from simulation #835

Merged
merged 1 commit into from
May 4, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented May 3, 2022

No description provided.

@pinosu pinosu requested a review from alpe as a code owner May 3, 2022 16:17
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -15,8 +15,7 @@ import (
"github.com/CosmWasm/wasmd/x/wasm/types"
)

//go:embed testdata/reflect.wasm
var reflectContract []byte
var reflectContract, _ = ioutil.ReadFile("../keeper/testdata/reflect.wasm")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like removing this duplicate. Otherwise they fall out of sync.

@ethanfrey ethanfrey merged commit fe347c6 into main May 4, 2022
@ethanfrey ethanfrey deleted the remove_duplicated_testdata branch May 4, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants