Reject invalid attributes #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 59.59% 59.65% +0.06%
==========================================
Files 45 45
Lines 5242 5260 +18
==========================================
+ Hits 3124 3138 +14
- Misses 1890 1892 +2
- Partials 228 230 +2
|
| } | ||
| value := strings.TrimSpace(l.Value) | ||
| if len(value) == 0 { | ||
| return nil, sdkerrors.Wrap(types.ErrInvalidEvent, fmt.Sprintf("Empty attribute value. Key: %s", key)) |
There was a problem hiding this comment.
Why is this check needed? Can't you have contracts that always set an attribute that is potentially empty (e.g. custom note)
There was a problem hiding this comment.
There is no way to search for this if it is empty. The syntax is <type>.<key> = <value>
I guess this might be allowed, I should check on the sdk side.
There was a problem hiding this comment.
I added a TODO and asked the sdk team if it is valid.
Shall we make the decision before merge?
There was a problem hiding this comment.
Alright. I'm fine either way and do not know what the best way to handle this is.
webmaster128
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #560
Return error on invalid events/attributes returned from contracts