Type safe bounds #627
Merged
Type safe bounds #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Jan 10, 2022
maurolacy
force-pushed
the
462-type-safe-bounds
branch
from
f9dcf3d to
bc1778e
Compare
ueco-jb
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
lgtm
Being nitpicky as I am, I'd consider changing test names slightly. I'm not sure what exactly range2_... means.
Initially I wanted to point out, that bound imports in unique.rs and multi.rs are without cfg = iteration mark, but then I noticed that types that uses them have those decorators in lib.rs. Nice that you were so precise about that.
Also, iterating over prefix is neat!
Will fix those. Thanks. |
Implement bounder for primitive types
Use tuple of IK and PK for multi index bound type
maurolacy
force-pushed
the
462-type-safe-bounds
branch
from
0150c85 to
a3ea930
Compare
Required for `edition2021` feature
ethanfrey
reviewed
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #462. Implements typed range bounds, following the same approach than
PrefixBound. Also introduces a couple raw variants, for flexibility and generality.Did all the changes in this PR, except for some refactoring, that will be published separately.
Lots of changes, but mostly cosmetic. The main impls are in keys.rs, where
Boundwas renamed toRawBound, and a new typedBoundwas introduced. All this will be moved to its ownbound.rsmodule for clarity (in a follow-up).There's also a new
Boundertrait, to build bounds from the keys (i.e.key.inclusive_bound()syntax), but it is mostly accessory / cosmetic.Some small follow-ups / questions from here:
prefix_range? After this new syntax for bounds,prefix_rangeis a little redundant. It's still clearer than using composite keys with empty elements. So, I'm not sure here.index_keyhelpers to return typed keys, or deprecate them entirely.prefix_range_raw()impls. If we don't deprecate it, let's add these for completeness in:SnapshotMapIndexedSnapshotMapUniqueIndexsub_prefix_range/_raw(). If we don't deprecate it, let's decide if we add these or not (only really useful for triple keys).Note:
CI checks are failing due to the no-iterator variant. Solved in #629.(fixed / merged)