Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cw721-base queries public #397

Closed

Conversation

shanev
Copy link
Contributor

@shanev shanev commented Aug 31, 2021

This is so contracts that extend cw721-base can call these queries directly, especially useful in unit tests.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021

CLA assistant check
All committers have signed the CLA.

@orkunkl
Copy link
Contributor

orkunkl commented Sep 1, 2021

@shanev Thanks! can you rebase/fix conflicting files? then we can merge

@orkunkl orkunkl requested review from ethanfrey, orkunkl, maurolacy and hashedone and removed request for maurolacy September 1, 2021 10:56
@maurolacy
Copy link
Contributor

maurolacy commented Sep 1, 2021

@shanev Thanks! can you rebase/fix conflicting files? then we can merge

Hmm, not sure if he would be able to do that properly, because we screwed main. Better thing would be to close this, and do it again against a rebased main.

Or, we do it ourselves, as these are simple / small changes. @orkunkl , can you take it?

Update: Already did it. See #399.

@maurolacy
Copy link
Contributor

Replaced by #399.

@maurolacy maurolacy closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants