Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexed map docs #340

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Indexed map docs #340

merged 6 commits into from
Jul 21, 2021

Conversation

maurolacy
Copy link
Contributor

Continuation / closure of #327.

@maurolacy maurolacy requested a review from ethanfrey July 21, 2021 11:37
@maurolacy
Copy link
Contributor Author

maurolacy commented Jul 21, 2021 •
edited
Loading

I'm now thinking that this can be improved by using &Addr as index key. Which will force me to fix all the new docs. :-)

ethanfrey
ethanfrey reviewed Jul 21, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice overview.

I added a few comments for improvements.

I would love it if @orkunkl could try reading it and give his feedback (as he has not been working on coding these types) to ensure we are not missing something obvious

packages/storage-plus/README.md Show resolved Hide resolved
packages/storage-plus/README.md Outdated Show resolved Hide resolved
packages/storage-plus/README.md Show resolved Hide resolved
packages/storage-plus/README.md Show resolved Hide resolved
contracts/cw721-base/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw721-base/src/contract.rs Outdated Show resolved Hide resolved
ethanfrey
ethanfrey approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks for the updates

packages/storage-plus/README.md Show resolved Hide resolved
@ethanfrey ethanfrey merged commit 2159c96 into main Jul 21, 2021
@ethanfrey ethanfrey deleted the indexed-map-docs branch July 21, 2021 17:58
@maurolacy maurolacy mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurolacy @ethanfrey