Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFrom for the decimals' respective integers #2075

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Implement TryFrom for the decimals' respective integers #2075

merged 4 commits into from
Mar 27, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Mar 27, 2024

Closes #2069

@aumetra aumetra requested a review from webmaster128 March 27, 2024 10:33
@aumetra aumetra force-pushed the aw/tryfrom-decimals branch from 7b0ff69 to bd234a5 Compare March 27, 2024 10:34
webmaster128
webmaster128 reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

While we are here, could you do the same for the signed version? I.e. add

  • Int256 -> SignedDecimal256
  • Int128 -> SignedDecimal

using the same pattern

@aumetra
Copy link
Member Author

aumetra commented Mar 27, 2024

Oh sure, completely overlooked those

@aumetra aumetra requested a review from webmaster128 March 27, 2024 10:47
@webmaster128
Copy link
Member

webmaster128 commented Mar 27, 2024 •
edited
Loading

CI is complaining about test coverage and kinda has a point here. Could you add a simple test for each of the functions? The majority of cases is handled by from_atomics tests.

@aumetra
Copy link
Member Author

aumetra commented Mar 27, 2024

Could you add a simple test for each of the functions?

Sure, the tests now assert the conversion was lossless (i.e. the Display impl of the decimal == Display impl of the integer)

webmaster128
webmaster128 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice. This tests the numeric value to be the same 👍

@aumetra aumetra merged commit 092d222 into main Mar 27, 2024
29 checks passed
@aumetra aumetra deleted the aw/tryfrom-decimals branch March 27, 2024 11:29
@webmaster128 webmaster128 mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conversion of Uint to Decimal too verbose
2 participants
@aumetra @webmaster128