Add default implementations for secp256r1_verify/secp256r1_recover_pubkey #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
webmaster128
force-pushed
the
unimplemented-api
branch
from
2f2ebc0 to
a28d679
Compare
aumetra
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks fine and also makes sense to not break downstream impls. But on that subject, is it even expected that people implement these traits themselves?
If not, then we should probably seal these traits next breaking release. That way we can do anything we want with these traits.
|
Contract developers don't implement then usually. However, if you build a testing framework and have your own version of MockApi with custom behaviour you need to implement it on the caller side. I don't know if those cases actually exist yet but we should support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2001