Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example PR 2 #5

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Example PR 2 #5

wants to merge 14 commits into from

Conversation

CoshUS
Copy link
Owner

@CoshUS CoshUS commented Nov 8, 2021

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS
Copy link
Owner Author

CoshUS commented Nov 9, 2021

Comment 1

@CoshUS
Copy link
Owner Author

CoshUS commented Nov 9, 2021

Comment 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant