Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Some Problems from Demo Examples #192

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

seanzhangkx8
Copy link
Collaborator

Description

Main changes throughout examples:

  1. replace occurrences of User (from older version) with Speaker (from new versions)
  2. modify minor errors within notebooks(replace utt id non exists, reference error, etc.)

Motivation and Context

To provide updated and correct examples for users to better understand how to use convokit.

How has this been tested?

Run in Jupyter notebook using newest version of ConvoKit (from GitHub main branch) with python version 3.9.0, following all contribution guidelines.

Copy link
Collaborator

@calebchiam calebchiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@calebchiam calebchiam merged commit 89f69fc into CornellNLP:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants