-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding of enum with associated values when enum case does not contain value #265
Fix decoding of enum with associated values when enum case does not contain value #265
Conversation
@MaxDesiatov , please comment or approve the PR |
I no longer maintain this library, please avoid pinging me in PRs or issues I don't work on. Thanks! |
@Joannis , maybe you could take a look? FYI: some tests are broken because of lack Swift support for codable enums with associated values in old versions of Xcode |
Thanks for pinging me @Alkenso , feel free to ping me anytime I overlook a PR or issue. |
2cba711
to
6661d69
Compare
@Joannis Please re-run failed job |
Looks very strange. Especially that all works fine on newer and older versions. |
@Alkenso a previous PR also failed on the same runner, I think this is a CI failure on Xcode 13.1/macOS 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Consider enum with associated values, where some value is empty
This PR fix decoding of such enum (while encoding is already worked as expected)
See new test in commit for details
Seems it also fixes #202