-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change load_array() -> load_layers(), return xr.Dataset #39
Conversation
Name changes, plus having load_layers() return an xr.Dataset object instead of an MLDataset object.
One variable naming thing related to this PR:
|
@PeterDSteinberg, just made the |
Searching shows just one docstring using Line 168 in 8ac7273
:X: should be :dset:
|
Otherwise - can merge when tests pass. |
Ah, thanks for pointing that one out. Just pushed up the fixes; waiting on tests to pass. |
With changes in the environment.yml / conda.recipe, can this line now be removed from build_earthio_env.sh? |
Yes, I believe so - just pushed up the change. |
Merged despite package upload failure - that issue will be addressed in a separate PR. |
Addresses #31 by changing
load_array()
toload_layers()
, and having the function return anxr.Dataset
object instead ofMLDataset
.