Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Update circleci build task to use correct context #1010

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(ci): Update circleci build task to use correct context #1010

merged 2 commits into from
Jul 10, 2024

Conversation

usmansaleem
Copy link
Contributor

PR Description

fix(ci): Update circleci build task to use correct context. This will allow main branch build task in CI to have correct context to run dependency check task as well as any unit or integration test involving external resources.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem usmansaleem requested a review from jframe July 10, 2024 00:42
jframe
jframe approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem enabled auto-merge (squash) July 10, 2024 01:21
@usmansaleem usmansaleem merged commit 2cbd5f6 into Consensys:master Jul 10, 2024
7 checks passed
@usmansaleem usmansaleem deleted the update_circleci_build_context branch October 15, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe