use forkChoiceUpdatedV4 with PayloadAttributesV4 #8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+252
to
+253
| maxBlobsPerBlock.map(maxBlobs -> maxBlobs.dividedBy(2)), | ||
| maxBlobsPerBlock)); |
There was a problem hiding this comment.
We probably want to have a unit test for this part of the code on ProposerDataManagerTest.
There was a problem hiding this comment.
I updated the ForkChoiceNotifierTest instead and added the new PayloadBuildingAttributes fields. I guess that's enough to cover the new code path
|
I think the changes look good. I just added a comment regarding a missing unit test and it looks like there are some other test failures to check. |
mehdi-aouadi
added a commit
to mehdi-aouadi/teku
that referenced
this pull request
Oct 31, 2024
mehdi-aouadi
added a commit
that referenced
this pull request
Oct 31, 2024
mehdi-aouadi
added a commit
to mehdi-aouadi/teku
that referenced
this pull request
Oct 31, 2024
lucassaldanha
pushed a commit
to lucassaldanha/teku
that referenced
this pull request
Nov 4, 2024
lucassaldanha
pushed a commit
to lucassaldanha/teku
that referenced
this pull request
Nov 4, 2024
mehdi-aouadi
added a commit
to mehdi-aouadi/teku
that referenced
this pull request
Nov 4, 2024
mehdi-aouadi
added a commit
that referenced
this pull request
Nov 4, 2024
* Decouple block and blobs publishing\import (#8728) * use correct schema definitions when creation full beacon block (#8806) * use correct schema definitions when creation full beacon block * use forkChoiceUpdatedV4 with PayloadAttributesV4 (#8752) (#8799) --------- Co-authored-by: Enrico Del Fante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Use
engine_forkChoiceUpdatedV4This PR should not be merged before the devnet-5 launch
Fixed Issue(s)
fixes #8745
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog