Add delete finalized state interface #8374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…ce' into Add-deleteFinalizedState-interface
rolfyone
reviewed
Jun 13, 2024
Comment on lines
+106
to
+107
| assertStateIsDeleted(state1.getSlot()); | ||
| assertStateIsDeleted(state2.getSlot()); |
There was a problem hiding this comment.
i know this is evil, but can we delete state 2 first?
There was a problem hiding this comment.
Do you mean in theory or you requesting a change there? anyway it's possible and the order doesn't matter at this level of the codebase, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the delete interface to the the V4FinalizedState, allowing deleting states by slot.
Necessary for the archive state pruner.
Fixed Issue(s)
Part of #8331
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog