Process attestations when the state from their target block state is available in cache #7142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
When selecting a state to use to process attestation gossip, check if the attestations
beaconBlockRoot
state is already available in the cache before deciding if it's worth regenerating a state. This allows us to process significantly more attestations without requiring additional state generations - particularly if attestations are received for blocks we just imported on a long fork.Also potentially reduces the number of generations we'd do during periods of non-finality by better leveraging what we have in cache.
Documentation
doc-change-required
label to this PR if updates are required.Changelog