Deprecate BeaconBlocksByRange.step #5565
Assignees
Comments
rolfyone
added a commit
to rolfyone/teku
that referenced
this issue
May 25, 2022
In line with 1.20 spec, the 'step' of blocksByRange must now always be 1. Need to evaluate that we can still accept a request with a step other than 1, and make it return the first block we find in that range fixes Consensys#5565 Signed-off-by: Paul Harris <[email protected]>
2 tasks
rolfyone
added a commit
that referenced
this issue
May 26, 2022
* update blocks by range to not skip blocks. In line with 1.20 spec, the 'step' of blocksByRange must now always be 1. Need to evaluate that we can still accept a request with a step other than 1, and make it return the first block we find in that range fixes #5565 Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Change our implementation of BeaconBlocksByRange to match the new deprecated implementation (only returns the first block).
Adjust any places we use a step > 1. I think this is just in CommonAncestorFinder.
See ethereum/consensus-specs#2856
The text was updated successfully, but these errors were encountered: