-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use already-built image in Dockerfile of l1-node-genesis-generator #669
Merged
jonesho
merged 3 commits into
main
from
638-genesis-generator-use-already-built-docker-image
Feb 13, 2025
Merged
feat: use already-built image in Dockerfile of l1-node-genesis-generator #669
jonesho
merged 3 commits into
main
from
638-genesis-generator-use-already-built-docker-image
Feb 13, 2025
+36
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
============================================
- Coverage 68.43% 68.38% -0.06%
Complexity 1185 1185
============================================
Files 323 323
Lines 13130 13131 +1
Branches 1318 1319 +1
============================================
- Hits 8986 8979 -7
- Misses 3593 3600 +7
- Partials 551 552 +1
*This pull request uses carry forward flags. Click here to find out more. |
jonesho
commented
Feb 11, 2025
02251e8
to
18a7faf
Compare
VGau
previously approved these changes
Feb 12, 2025
04f9244
to
57bceba
Compare
VGau
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #638
ethpandaops/ethereum-genesis-generator
in Dockerfile ofl1-node-genesis-generator
L1_GENESIS_TIME
optional in the docker compose fileChecklist