Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics in GlobalBlobAwareConflationCalculator and move bri… #654

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Feb 5, 2025

…dge logs and state root hash retrieval from execution prover client to coordinator

This PR implements issue(s) #604

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

…dge logs and state root hash retrieval from execution prover client to coordinator
@jonesho jonesho self-assigned this Feb 5, 2025
@jonesho jonesho marked this pull request as draft February 5, 2025 08:10
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 5, 2025 08:11 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e February 5, 2025 08:17 — with GitHub Actions Error
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 68.46%. Comparing base (b5194c0) to head (1412aaf).

Files with missing lines Patch % Lines
...clients/prover/FileBasedExecutionProverClientV2.kt 0.00% 10 Missing ⚠️
...in/kotlin/net/consensys/zkevm/domain/Conflation.kt 25.00% 7 Missing and 2 partials ⚠️
.../conflation/GlobalBlobAwareConflationCalculator.kt 89.61% 4 Missing and 4 partials ⚠️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 6 Missing ⚠️
...on/proofcreation/ZkProofCreationCoordinatorImpl.kt 94.28% 2 Missing ⚠️
.../coordinator/clients/prover/ProverClientFactory.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #654      +/-   ##
============================================
+ Coverage     68.35%   68.46%   +0.10%     
- Complexity     1181     1197      +16     
============================================
  Files           323      323              
  Lines         13125    13215      +90     
  Branches       1316     1325       +9     
============================================
+ Hits           8972     9047      +75     
- Misses         3599     3610      +11     
- Partials        554      558       +4     
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø) Carriedforward from b09cb4f
kotlin 66.13% <76.00%> (+0.12%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...tor/clients/BatchExecutionProverRequestResponse.kt 81.81% <100.00%> (+37.37%) ⬆️
...on/conflation/BlockToBatchSubmissionCoordinator.kt 92.10% <100.00%> (+0.43%) ⬆️
...conflation/ConflationCalculatorByDataCompressed.kt 96.00% <100.00%> (ø)
.../coordinator/clients/prover/ProverClientFactory.kt 62.50% <0.00%> (+2.15%) ⬆️
...on/proofcreation/ZkProofCreationCoordinatorImpl.kt 95.00% <94.28%> (+95.00%) ⬆️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 1.45% <0.00%> (-0.01%) ⬇️
.../conflation/GlobalBlobAwareConflationCalculator.kt 93.33% <89.61%> (-1.75%) ⬇️
...in/kotlin/net/consensys/zkevm/domain/Conflation.kt 59.37% <25.00%> (-0.28%) ⬇️
...clients/prover/FileBasedExecutionProverClientV2.kt 0.00% <0.00%> (-59.02%) ⬇️

... and 3 files with indirect coverage changes

@jonesho jonesho temporarily deployed to docker-build-and-e2e February 5, 2025 08:47 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 5, 2025 09:30 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants