Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: build docker wo rust corset #419

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

AlexandreBelling
Copy link
Contributor

Corset takes up 2 min of docker build on the CI and we don't use it in the prover directly anymore.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling added Prover Tag to use for all work impacting the prover Minor improvements The PR fixes typos or brings minor improvements labels Dec 10, 2024
@AlexandreBelling AlexandreBelling self-assigned this Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.18%. Comparing base (bc0cfbb) to head (36eadc1).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #419   +/-   ##
=========================================
  Coverage     68.18%   68.18%           
  Complexity     1125     1125           
=========================================
  Files           319      319           
  Lines         12789    12789           
  Branches       1275     1275           
=========================================
  Hits           8720     8720           
  Misses         3541     3541           
  Partials        528      528           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 65.80% <ø> (ø) Carriedforward from bc0cfbb

*This pull request uses carry forward flags. Click here to find out more.

@AlexandreBelling AlexandreBelling force-pushed the prover/build-docker-wo-rust-corset branch from 39cdde1 to 36eadc1 Compare December 18, 2024 14:10
@AlexandreBelling AlexandreBelling merged commit 8fa0a1c into main Dec 18, 2024
25 checks passed
@AlexandreBelling AlexandreBelling deleted the prover/build-docker-wo-rust-corset branch December 18, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor improvements The PR fixes typos or brings minor improvements Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants