Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: emulated/fields_bn254 #532

Closed
wants to merge 21 commits into from
Closed

Test: emulated/fields_bn254 #532

wants to merge 21 commits into from

Conversation

yelhousni
Copy link
Contributor

@yelhousni yelhousni commented Mar 7, 2023 •
edited
Loading

Needs Consensys/gnark-crypto#354 to be merged on gnark-crypto side

ivokub and others added 17 commits February 21, 2023 12:38
@ivokub
feat: add BN254 pairing using field emulation
40e45b0
@ivokub
refactor: make methods private
026133b
@ivokub
feat: add equality assertion for GT elements
41d98e2
@ivokub
docs: add package documentation and example
c2f401d
@ivokub
Merge branch 'develop' into feat/nonnative-pairing
8219e39
@yelhousni
refactor: algebra into native (2-chain) and emulated
0984911
@yelhousni
Merge branch 'develop' into refactor/std/algebra
61b2833
@yelhousni
fix: remove pairing_bn254
1d76c58
@yelhousni
fix: use sw_emulated instead of weierstrass
130ed80
@yelhousni
fix: update path to algebra/native
e88b1df
@yelhousni
fix: update path to algebra/native
440afdb
@yelhousni
fix: update path to algebra/native/twistededwards
00d4c1a
@yelhousni
docs: add documentation to std/algebra packages
904cbc0
@yelhousni
style(std/fields_*): separate Fpk ops specific to choice of pairing
f2b7910
@yelhousni
test: add emulated Fp2 tests
d400c0b
@yelhousni
test: add emulated Fp6 tests
26b9968
@yelhousni
test: add emulated Fp12 tests
93d9103
@yelhousni yelhousni added cleanup consolidate strengthen an existing feature labels Mar 7, 2023
@yelhousni yelhousni requested review from ivokub and gbotrel March 7, 2023 11:42
@yelhousni yelhousni marked this pull request as draft March 7, 2023 11:42
This was referenced Mar 7, 2023
Merged
Merged
@yelhousni yelhousni self-assigned this Mar 7, 2023
@yelhousni yelhousni marked this pull request as ready for review March 7, 2023 16:03
ivokub
ivokub approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing on top of refactored algebra and gnark-crypto update, looks good. There are a few notes about nice-to-have element initialization methods.

std/algebra/emulated/fields_bn254/e2.go Outdated Show resolved Hide resolved
std/algebra/emulated/fields_bn254/e2.go Outdated Show resolved Hide resolved
std/algebra/emulated/fields_bn254/e6.go Outdated Show resolved Hide resolved
std/algebra/emulated/fields_bn254/e12.go Outdated Show resolved Hide resolved
@gbotrel gbotrel added the zk-evm label Mar 14, 2023
@yelhousni yelhousni mentioned this pull request Mar 14, 2023
Merged
@yelhousni
Copy link
Contributor Author

Closing this PR as it is included in #566 with some added and modified tests there.

@yelhousni yelhousni closed this Mar 17, 2023
@gbotrel gbotrel deleted the test/emulated/fields_bn254 branch August 21, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

@gbotrel gbotrel Awaiting requested review from gbotrel

Assignees

@yelhousni yelhousni

Labels
cleanup consolidate strengthen an existing feature zk-evm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yelhousni @ivokub @gbotrel