Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make pedersen vk fields public #488

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

ahmetyalp
Copy link
Contributor

@ahmetyalp ahmetyalp commented Feb 14, 2024

Description

This PR makes pedersen.VerifyingKey fields (G and GRootSigmaNeg) public to be able to read/copy at gnark/std/recursion/groth16/verifier.ValueOfVerifyingKey

Type of change

How has this been tested?

How has this been benchmarked?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub self-requested a review February 15, 2024 23:46
@ivokub ivokub self-assigned this Feb 15, 2024
@ivokub ivokub added the consolidate strengthen an existing feature label Feb 15, 2024
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for the contribution!

@ivokub ivokub merged commit d72fcb3 into Consensys:master Feb 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants