Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide DG detection option #431

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Unhide DG detection option #431

merged 3 commits into from
Feb 14, 2023

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Feb 10, 2023

Pull request checklist

Use the following template to make sure your PR fits the Teku documentation standard.

Before creating the PR

Make sure that:

Describe the change

Unhide the doppelganger detection option:

  • Remove the X from the Doppelganger Detection How To page
  • Add a doppelganger-detection-enabled CLI option

Issue fixed

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • CircleCI workflow
  • Build and QA tools (for example lint or vale)
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

  • You've fixed any issues raised by the tests.
  • You've previewed your changes with Vercel below.

Preview

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
doc-teku ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 3:03AM (UTC)

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor edits, LGTM!

@alexandratran alexandratran merged commit 2fd4454 into Consensys:main Feb 14, 2023
@mehdi-aouadi mehdi-aouadi deleted the dg-detection-option branch February 14, 2023 09:38
mehdi-aouadi added a commit that referenced this pull request Feb 14, 2023
mehdi-aouadi added a commit that referenced this pull request Feb 14, 2023
mehdi-aouadi added a commit that referenced this pull request Mar 9, 2023
mehdi-aouadi added a commit that referenced this pull request Mar 15, 2023
* Unhide DG detection option (#431)
---------
Co-authored-by: Alexandra Tran Carrillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants