Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap builtin processors in middleware in examples #1748

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Aug 6, 2024

Description

This is needed so that the generated specs and consequently the generated documentation contain the middleware parameters.

EDIT: also added the following changes:

  • simplified how processor specs are exported (used ENV var instead of build tag, allowing me to remove 8 files)
  • disabled schema middleware in error and filter processors (they have no use for it)

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner August 6, 2024 11:27
@lovromazgon lovromazgon force-pushed the lovro/builtin-processor-example-middleware branch from e077aa5 to 3e67929 Compare August 6, 2024 11:55
@lovromazgon lovromazgon merged commit 306defe into main Aug 6, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/builtin-processor-example-middleware branch August 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants