Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and examples for converting time using field.convert #1745

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

lovromazgon
Copy link
Member

Description

The title pretty much describes it. One small but important change is the line where we ensure the timezone is set to UTC when converting the value.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner August 5, 2024 18:18
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lovromazgon lovromazgon enabled auto-merge (squash) August 6, 2024 10:43
@lovromazgon lovromazgon merged commit 3a9d244 into main Aug 6, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/field-convert-example branch August 6, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants