Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sets environment variable based on log level #1740

Merged
merged 6 commits into from
Aug 2, 2024
Merged

feat: sets environment variable based on log level #1740

merged 6 commits into from
Aug 2, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Aug 2, 2024 •
edited
Loading

Description

Makes use of https://github.com/ConduitIO/conduit-connector-protocol/blob/main/pconnutils/env_vars.go#L21 which is set by connectors via ConduitIO/conduit-connector-sdk#164

⚠️ It's currently depending on:

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb mentioned this pull request Aug 2, 2024
Merged
4 tasks
@raulb raulb marked this pull request as ready for review August 2, 2024 10:43
@raulb raulb requested a review from a team as a code owner August 2, 2024 10:43
@raulb raulb self-assigned this Aug 2, 2024
lovromazgon
lovromazgon approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@raulb raulb merged commit a8d76dc into main Aug 2, 2024
3 checks passed
@raulb raulb deleted the raul/set-log-level branch August 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees

@raulb raulb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulb @lovromazgon