Add handling for time.Time in avro encode processor #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirketema
commented
Jun 12, 2024
pkg/plugin/processor/builtin/impl/avro/schemaregistry/avro/extractor.go
Outdated
Show resolved
Hide resolved
samirketema
commented
Jun 12, 2024
pkg/plugin/processor/builtin/impl/avro/schemaregistry/encoder.go
Outdated
Show resolved
Hide resolved
lyuboxa
force-pushed
the
samir/avro-types
branch
from
7239c52 to
be3c496
Compare
This change is only applicable for builtin connectors, since complex types such as `time.Time` are not allowed in standalone connector due to restrictions in the plugin framework.
lyuboxa
force-pushed
the
samir/avro-types
branch
from
be3c496 to
899721d
Compare
lyuboxa
changed the title
|
@lovromazgon fixed here 513697c |
lovromazgon
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is only applicable for builtin connectors, since complex types such as
time.Timeare notallowed in standalone connector due to restrictions in the plugin framework.
Quick checks: