Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for converting []byte to string #1463

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add support for converting []byte to string #1463

merged 1 commit into from
Apr 2, 2024

Conversation

lovromazgon
Copy link
Member

Description

I discovered this issue while working on my champagne project. I expected the field.convert processor to be able to convert raw []byte to string. This change makes it able to do that.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner April 2, 2024 12:19
@lovromazgon lovromazgon merged commit 647e462 into main Apr 2, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/field-convert-bytes branch April 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovromazgon @hariso