Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused #1429

Merged
merged 3 commits into from
Mar 11, 2024
Merged

chore: remove unused #1429

merged 3 commits into from
Mar 11, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Mar 11, 2024 •
edited
Loading

Description

These files are unused and currently requires a dependency with https://grpc.io/docs/protoc-installation/ when running make generate.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb marked this pull request as ready for review March 11, 2024 14:04
@raulb raulb requested a review from a team as a code owner March 11, 2024 14:04
@raulb raulb self-assigned this Mar 11, 2024
@raulb raulb force-pushed the remove-unused-doc branch from 114e5b7 to bd3f496 Compare March 11, 2024 14:07
lovromazgon
lovromazgon approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up.

@raulb raulb merged commit 81009b5 into main Mar 11, 2024
3 checks passed
@raulb raulb deleted the remove-unused-doc branch March 11, 2024 14:25
@lovromazgon lovromazgon mentioned this pull request Mar 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees

@raulb raulb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulb @lovromazgon