Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: site updates #88

Merged
merged 18 commits into from
May 13, 2024
Merged

feat: site updates #88

merged 18 commits into from
May 13, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented May 9, 2024

  • Upgrade dependencies
  • Consolidate /docs as the main url for Documentation to apply to Algolia Search with a better URL.
  • Update Twitter logo

Before

image

After

image
  • Restructure pages consolidating what's duplicated

Copy link

cloudflare-workers-and-pages bot commented May 9, 2024

Deploying conduit-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff92774
Status: ✅  Deploy successful!
Preview URL: https://578c4716.conduit-site.pages.dev
Branch Preview URL: https://ui-updates.conduit-site.pages.dev

View logs

@raulb raulb marked this pull request as ready for review May 13, 2024 12:48
@raulb raulb requested a review from a team as a code owner May 13, 2024 12:48
@raulb raulb self-assigned this May 13, 2024
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes @raulb 👏 I added a few suggestions, lmk what you think.

docs/getting-started/installing-and-running.mdx Outdated Show resolved Hide resolved
docs/introduction.mdx Outdated Show resolved Hide resolved
src/components/HomepageNavbar/index.tsx Show resolved Hide resolved
docs/getting-started/getting-started.mdx Show resolved Hide resolved
docs/getting-started/installing-and-running.mdx Outdated Show resolved Hide resolved
docs/getting-started/installing-and-running.mdx Outdated Show resolved Hide resolved
@raulb raulb requested a review from lovromazgon May 13, 2024 16:31
@raulb
Copy link
Member Author

raulb commented May 13, 2024

@lovromazgon thanks for the feedback. I think I addressed it all. Let me know what you think. There's still something I'd like to do (if possible) which is hiding this section for the installation page:

@lovromazgon
Copy link
Member

lovromazgon commented May 13, 2024

There's still something I'd like to do (if possible) which is hiding this section for the installation page

@raulb try adding this to the top of the file:

--- 
# other options ...
hide_table_of_contents: true
---

Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@raulb
Copy link
Member Author

raulb commented May 13, 2024

There's still something I'd like to do (if possible) which is hiding this section for the installation page

@raulb try adding this to the top of the file:

--- 
# other options ...
hide_table_of_contents: true
---

Nice thank you @lovromazgon. This actually plays out nicely in that page so we can have more real state for the terminal.

@raulb raulb merged commit 50dd4a9 into main May 13, 2024
1 check passed
@raulb raulb deleted the ui-updates branch May 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants