Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new scarf pixels to docs #178

Merged
merged 2 commits into from
Oct 24, 2024
Merged

add new scarf pixels to docs #178

merged 2 commits into from
Oct 24, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Oct 24, 2024

old pixels on scarf now have "not-used" at the end of the name, to keep the hitory.
new pixels are created according to the directory names, only two old pixels are reused and renamed (introductions and builtin processors)

fixes #175

@maha-hajja maha-hajja requested a review from a team as a code owner October 24, 2024 05:55
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2024

Deploying conduit-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 752904a
Status: ✅  Deploy successful!
Preview URL: https://79fa2341.conduit-site.pages.dev
Branch Preview URL: https://maha-new-pixels.conduit-site.pages.dev

View logs

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Maha! There were some broken links because of something I missed in a previous PR. I just updated this one and opened a PR on Conduit to fix the spec sources: ConduitIO/conduit#1928.

@raulb raulb merged commit 4cc1025 into main Oct 24, 2024
1 check passed
@raulb raulb deleted the maha/new-pixels branch October 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Add scarf pixel to the changelog page
2 participants