-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avro schema generator #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8cb784
to
779bd2c
Compare
hariso
reviewed
Jun 24, 2024
hariso
reviewed
Jun 24, 2024
hariso
reviewed
Jun 24, 2024
hariso
reviewed
Jun 24, 2024
hariso
reviewed
Jun 24, 2024
hariso
reviewed
Jun 24, 2024
hariso
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyuboxa @samirketema I left a few comments, I'm mostly interested in nullability of columns and that we're fine with the list of supported types for now. Awesome work!
hariso
approved these changes
Jun 24, 2024
hariso
approved these changes
Jun 24, 2024
1c5aec6
to
69406e0
Compare
c9125c1
to
75953bb
Compare
maha-hajja
approved these changes
Jun 24, 2024
4b69d7e
to
75953bb
Compare
lovromazgon
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to generate an Avro schema for each
snapshot
,create
andupdate
operations.The avro schema is rendered in JSON and added to each record under the
postgres.avro.schema
metadata key.The schema may be used to hint about types where precision or other may be lost as they are converted to go types, e.g. dates, numeric, etc.
Usage of the schema is a temporary measure until Conduit schema management is released.
In order for the schema to be emitted, the following config var will need to be set
logrepl.withAvroSchema
Quick checks: