Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_consensus_detailed_status query. #226

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Add get_consensus_detailed_status query. #226

merged 3 commits into from
Jan 28, 2025

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jan 27, 2025 •
edited
Loading

Purpose

Addresses: #216
Depends on: Concordium/concordium-base#595

Add support for the GetConsensusDetailedStatus enpoint.

Changes

  • Add types and conversions.
  • Add get_consensus_detailed_status.
  • Add simple example.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 force-pushed the consensus-detailed-status branch from 823b1a8 to af95466 Compare January 27, 2025 14:41
@td202 td202 requested review from limemloh and drsk0 January 27, 2025 14:41
drsk0
drsk0 approved these changes Jan 27, 2025
View reviewed changes
Copy link

@drsk0 drsk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

src/types/block_certificates.rs Outdated Show resolved Hide resolved
@td202 td202 merged commit 5cf2948 into main Jan 28, 2025
4 checks passed
@td202 td202 deleted the consensus-detailed-status branch January 28, 2025 16:43
@td202 td202 mentioned this pull request Jan 28, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drsk0 drsk0 drsk0 approved these changes

@limemloh limemloh Awaiting requested review from limemloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@td202 @drsk0