Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize to the correct chain parameters version. #591

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Serialize to the correct chain parameters version. #591

merged 1 commit into from
Jan 14, 2025

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jan 14, 2025 •
edited
Loading

Purpose

Related issue: Concordium/concordium-node#1312

Ensure ChainParmetersV3 is correctly serialized in protobuf.

Changes

  • Use v3 instead of v2.
  • Include the validatorScoreParameters.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 merged commit 67227da into main Jan 14, 2025
40 checks passed
@td202 td202 deleted the grpc-cpv3 branch January 14, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drsk0 drsk0 drsk0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@td202 @drsk0