Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator score chain parameters #571

Merged
merged 13 commits into from
Dec 4, 2024
Merged

Validator score chain parameters #571

merged 13 commits into from
Dec 4, 2024

Conversation

drsk0
Copy link
Contributor

@drsk0 drsk0 commented Nov 18, 2024

Purpose

Add validator score parameters to chain parameters. The grpc changes need to go in first (Concordium/concordium-grpc-api#66)

Changes

This adds new parameters for validator suspension and all the necessary boilerplate code.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@drsk0 drsk0 requested a review from td202 November 18, 2024 15:36
@drsk0 drsk0 force-pushed the score_chain_param branch from 30db762 to 4a91118 Compare November 20, 2024 10:25
@td202
Copy link
Contributor

td202 commented Nov 20, 2024

This approach seems fine. I think the GRPC interface will need to be updated to.

@drsk0 drsk0 force-pushed the score_chain_param branch 8 times, most recently from c0d4ad0 to 948cd09 Compare November 25, 2024 10:43
@drsk0 drsk0 marked this pull request as ready for review November 25, 2024 10:43
@drsk0 drsk0 requested a review from td202 November 25, 2024 10:43
@drsk0 drsk0 changed the title draft for new chain param Validator score chain parameters Nov 25, 2024
@drsk0 drsk0 force-pushed the score_chain_param branch 4 times, most recently from d6e127f to 3dfc59c Compare November 25, 2024 16:02
haskell-src/Concordium/Types/Parameters.hs Outdated Show resolved Hide resolved
haskell-src/Concordium/Types/Parameters.hs Show resolved Hide resolved
haskell-src/Concordium/Types/Parameters.hs Outdated Show resolved Hide resolved
@drsk0 drsk0 force-pushed the score_chain_param branch from 422e92a to 7f16079 Compare December 2, 2024 17:20
@drsk0 drsk0 force-pushed the score_chain_param branch from 7f16079 to 7c67b93 Compare December 3, 2024 11:09
@drsk0 drsk0 mentioned this pull request Dec 3, 2024
6 tasks
@drsk0 drsk0 requested a review from td202 December 3, 2024 12:44
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to define an UpdatePayload constructor (in Updates.hs) for updating the new chain parameter.

@drsk0
Copy link
Contributor Author

drsk0 commented Dec 3, 2024

@td202 I added the new update type to Update.hs. The grpc api also needs to be extended: Concordium/concordium-grpc-api#71.

@drsk0 drsk0 force-pushed the score_chain_param branch from c32917f to a85ec5c Compare December 3, 2024 15:27
Add support for newly introduced special transaction outcomes for validator suspension.
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Main thing missing is the handling of the new update payload in GRPC2.hs.

haskell-src/Concordium/GRPC2.hs Show resolved Hide resolved
concordium-grpc-api Outdated Show resolved Hide resolved
haskell-src/Concordium/Types/Queries.hs Outdated Show resolved Hide resolved
haskell-src/Concordium/GRPC2.hs Outdated Show resolved Hide resolved
@drsk0 drsk0 force-pushed the score_chain_param branch from c0965a4 to af5c334 Compare December 4, 2024 11:29
@drsk0 drsk0 requested a review from td202 December 4, 2024 11:30
@drsk0 drsk0 force-pushed the score_chain_param branch from af5c334 to e16cc74 Compare December 4, 2024 11:40
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@drsk0 drsk0 merged commit b4036e6 into main Dec 4, 2024
40 checks passed
@drsk0 drsk0 deleted the score_chain_param branch December 4, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants