-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator score chain parameters #571
Conversation
30db762
to
4a91118
Compare
This approach seems fine. I think the GRPC interface will need to be updated to. |
c0d4ad0
to
948cd09
Compare
d6e127f
to
3dfc59c
Compare
422e92a
to
7f16079
Compare
7f16079
to
7c67b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to define an UpdatePayload
constructor (in Updates.hs
) for updating the new chain parameter.
@td202 I added the new update type to |
c32917f
to
a85ec5c
Compare
Add support for newly introduced special transaction outcomes for validator suspension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Main thing missing is the handling of the new update payload in GRPC2.hs.
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
c0965a4
to
af5c334
Compare
af5c334
to
e16cc74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
Purpose
Add validator score parameters to chain parameters. The grpc changes need to go in first (Concordium/concordium-grpc-api#66)
Changes
This adds new parameters for validator suspension and all the necessary boilerplate code.
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.