Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bs58 and ed25519-zebra dependencies. #504

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Update bs58 and ed25519-zebra dependencies. #504

merged 3 commits into from
Jan 22, 2024

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Jan 21, 2024

Purpose

Update bs58 and ed25519-zebra dependencies to avoid duplicate transitive dependencies after the ed25519-dalek upgrade.

Changes

  • The zebra upgrade has no API changes, simply an upgrade of curve25519-dalek.
  • The bs58 has a few API changes, the only one relevant for us is renaming into to onto.
  • Use ChaCha20Rng instead of StdRng. In the update from 0.7 to 0.8 of rand the StdRng was changed from ChaCha20 to ChaCha12 leading to some test failures due to hardcoded constants.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak abizjak requested a review from annenkov January 21, 2024 13:13
Copy link
Contributor

@annenkov annenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@abizjak abizjak merged commit 8024cee into main Jan 22, 2024
67 checks passed
@abizjak abizjak deleted the update-deps branch January 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants