Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New curve interfaces #484

Merged
merged 50 commits into from
Jan 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
209afce
Add custom traits Field and PrimeField with a blanket implementation …
annenkov Oct 5, 2023
3324f36
Do not use PrimeField where Field is enough
annenkov Oct 5, 2023
9a2ec6d
Add curve25519 implementation stub
annenkov Oct 6, 2023
159ca8a
Implement Field/Curve traits for ed25519 (WIP)
hamiidreza Nov 9, 2023
fe5be05
curve25519 WIP
annenkov Nov 9, 2023
4eb4b0e
Curve25519 Added
hamiidreza Nov 13, 2023
45c2bc1
minor fixes
hamiidreza Nov 13, 2023
37fcf8c
Add benches
annenkov Nov 13, 2023
43d286b
Add ed25519_ng implementation; add dalek's bulletproof benchmark
annenkov Nov 14, 2023
7a2005c
msm benchmark
hamiidreza Nov 17, 2023
8610c74
Use different multiexp implementations: generic of BSL and special fo…
annenkov Nov 22, 2023
2cc21a7
Comment on msm benchmark
annenkov Nov 22, 2023
b2e6897
Change MultiExp interface a bit; GenericMultiExp::new takes window_size
annenkov Nov 24, 2023
5ccd66f
Arkworks integration WIP
annenkov Nov 27, 2023
f452d5d
Merge branch 'main' into new-curves
annenkov Nov 27, 2023
89c71bf
Fix clippy warnings
annenkov Nov 27, 2023
d6edf65
Clean-up: remove experimental code; fix imports; constants and comments
annenkov Nov 27, 2023
5b128fe
Use RistrettoMultiExpNoPrecompute as multiexp for ristretto
annenkov Nov 27, 2023
91306b5
Remove unused import and redundant comment
annenkov Nov 27, 2023
b48d1fd
Cleanup
annenkov Nov 27, 2023
cfa3b59
Update CHANGELOG
annenkov Nov 28, 2023
c732939
Cleanup; set GROUP_ELEMENT_LENGTH to 32 for curve25519
annenkov Nov 28, 2023
9de8c22
Remove ArkWorks stuff
annenkov Nov 29, 2023
8876529
Remove pprof profiling dependency; add curve25519-dalek-ng to dev dep…
annenkov Nov 29, 2023
9897928
Dependencies in Cargo.lock
annenkov Nov 29, 2023
1cca837
removed dalek range bench
hamiidreza Dec 5, 2023
78fd866
minor
hamiidreza Dec 5, 2023
23a835b
msm_bench clean-up
hamiidreza Dec 6, 2023
92be6ff
range_proof_bench clean-up
hamiidreza Dec 6, 2023
0e6b2b9
Remove todos
annenkov Dec 13, 2023
40f9132
Remove Display from Field constraints
annenkov Dec 13, 2023
1d8027f
Drive from, comment on unwrapping in into_repr()
annenkov Dec 13, 2023
e7bbf67
Apply suggestions from code review
annenkov Dec 13, 2023
6d19f44
Merge branch 'new-curves' of github.com:Concordium/concordium-base in…
annenkov Dec 13, 2023
2bea108
Remove redundant dependencies
annenkov Dec 13, 2023
287a2b8
Adding tests for ed25519
hamiidreza Dec 19, 2023
7451a6f
removing unnecessary tests
hamiidreza Dec 20, 2023
0463cd9
Apply suggestions from code review
hamiidreza Dec 20, 2023
46c9ac0
Apply suggestions from code review
hamiidreza Dec 20, 2023
5facd01
Apply suggestions from code review
hamiidreza Dec 20, 2023
c459bc3
Add tests for into_repr() and scalar_from_bytes()
annenkov Dec 21, 2023
7ecae74
Merge branch 'new-curves' of github.com:Concordium/concordium-base in…
annenkov Dec 21, 2023
a1f5187
Fix curve25519 tests
annenkov Dec 22, 2023
6da6568
Merge branch 'main' into new-curves
annenkov Dec 22, 2023
f5e5873
Add comments to curve25519 tests
annenkov Dec 22, 2023
134d1f1
Merge branch 'new-curves' of github.com:Concordium/concordium-base in…
annenkov Dec 22, 2023
f75deb8
Apply suggestions from code review
annenkov Jan 2, 2024
a85d36a
Fix comments
annenkov Jan 2, 2024
c51bdeb
Remove ff::BitIterator, use pow_vartime implementation from newer ver…
annenkov Jan 2, 2024
7d72684
Add a comment about double; remove commented out line
annenkov Jan 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fixes
  • Loading branch information
hamiidreza committed Nov 13, 2023
commit 45c2bc1beadda7dbac6fa39420c3cabdf47615c4
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ impl PrimeField for RistrettoScalar {
}

fn from_repr(r: &[u64]) -> Result<Self, super::CurveDecodingError> {
let mut tmp: [u64; 4] = r.try_into().map_err(|e| super::CurveDecodingError::NotInField(format!("{:?}", r)))?;
let tmp: [u64; 4] = r.try_into().map_err(|_| super::CurveDecodingError::NotInField(format!("{:?}", r)))?;
let mut s_bytes = [0u8; 32];
for x in tmp {
LittleEndian::write_u64(&mut s_bytes, x);
Expand Down