Add implementation for std::hash::Hash for HashBytes #295

soerenbf · 2023-01-13T14:08:50Z

Purpose

Added Hash trait to hashbytes type to be able to use it in data structures requiring the Hash trait (such as HashMap)

My code follows the style of this project.
The code compiles without warnings.
I have performed a self-review of the changes.
I have documented my code, in particular the intent of the
hard-to-understand areas.
(If necessary) I have updated the CHANGELOG.

rust-src/concordium_base/src/hashes.rs

Co-authored-by: Aleš Bizjak <[email protected]>

soerenbf requested review from abizjak and MilkywayPirate January 13, 2023 14:08

soerenbf self-assigned this Jan 13, 2023

abizjak approved these changes Jan 13, 2023

View reviewed changes

soerenbf force-pushed the hash-trait-hashbytes branch 2 times, most recently from 5e5fbb4 to d021b26 Compare January 13, 2023 14:20

Add implementation for std::hash::Hash for HashBytes

0863d14

soerenbf force-pushed the hash-trait-hashbytes branch from d021b26 to 0863d14 Compare January 13, 2023 16:13

MilkywayPirate approved these changes Jan 13, 2023

View reviewed changes

abizjak reviewed Jan 13, 2023

View reviewed changes

rust-src/concordium_base/src/hashes.rs Show resolved Hide resolved

Explicit Eq impl for HashBytes

3b02d3f

soerenbf requested a review from abizjak January 14, 2023 12:34

abizjak approved these changes Jan 14, 2023

View reviewed changes

rust-src/concordium_base/src/hashes.rs Outdated Show resolved Hide resolved

soerenbf and others added 2 commits January 14, 2023 13:47

Update rust-src/concordium_base/src/hashes.rs

df8244a

Co-authored-by: Aleš Bizjak <[email protected]>

fit fmt error

e30ff70

soerenbf merged commit 3863d95 into main Jan 14, 2023

soerenbf deleted the hash-trait-hashbytes branch January 14, 2023 16:43