Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dotnet-isolated runtime. #598

Conversation

viktorvan
Copy link
Contributor

@viktorvan viktorvan commented Mar 30, 2021

This PR closes #596

The changes in this PR are as follows:

  • Add RuntimeKind for DotNet runtime for Azure Functions to enable running as dotnet-isolated.

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:
No docs updated, the runtime options are not currently listed in the docs.

@viktorvan viktorvan marked this pull request as ready for review April 9, 2021 07:04
@viktorvan
Copy link
Contributor Author

The default runtime, when no runtime is explicitly set is still "dotnet". In the future maybe it will make sense to make "dotnet-isolated" the default.

Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend just adding the DotNetIsolated case to keep the use_runtime call simple.

type RuntimeKind =
| Isolated
| InProcess
type FunctionsRuntime = DotNet of RuntimeKind | Node | Java | Python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than introducing the RuntimeKind type that is only specific to the DotNet case, it would be easier to use if DotNetIsolated is just another case altogether that represents the "dotnet-isolated" option. Then the usage remains simple like

use_runtime DotNet

or

use_runtime DotNetIsolated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good point, use_runtime DotNetIsolated feels better than use_runtime (DotNet Isolated).

Since the RuntimeKind was an idea from @isaacabraham maybe he wants to weigh in as well? Should we just go with a DotNetIsolated case?

Copy link
Collaborator

@ninjarobot ninjarobot Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am thinking from the perspective of use_runtime in the DSL, but I would definitely like to get perspective from @isaacabraham as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isaacabraham can you please comment on this as to whether or not to break out the RuntimeKind for these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think merging them will be better from a public API consumption point of view.

@ninjarobot ninjarobot added this to the 1.5 milestone Apr 22, 2021
@ninjarobot ninjarobot merged commit 7994724 into CompositionalIT:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add runtime-option "dotnet-isolated" for Azure Functions
3 participants