-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dotnet-isolated runtime. #598
Add support for dotnet-isolated runtime. #598
Conversation
The default runtime, when no runtime is explicitly set is still "dotnet". In the future maybe it will make sense to make "dotnet-isolated" the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend just adding the DotNetIsolated
case to keep the use_runtime
call simple.
type RuntimeKind = | ||
| Isolated | ||
| InProcess | ||
type FunctionsRuntime = DotNet of RuntimeKind | Node | Java | Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than introducing the RuntimeKind
type that is only specific to the DotNet
case, it would be easier to use if DotNetIsolated
is just another case altogether that represents the "dotnet-isolated" option. Then the usage remains simple like
use_runtime DotNet
or
use_runtime DotNetIsolated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good point, use_runtime DotNetIsolated
feels better than use_runtime (DotNet Isolated)
.
Since the RuntimeKind was an idea from @isaacabraham maybe he wants to weigh in as well? Should we just go with a DotNetIsolated
case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am thinking from the perspective of use_runtime
in the DSL, but I would definitely like to get perspective from @isaacabraham as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaacabraham can you please comment on this as to whether or not to break out the RuntimeKind
for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think merging them will be better from a public API consumption point of view.
This PR closes #596
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
No docs updated, the runtime options are not currently listed in the docs.