Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added route table support for subnets #1155

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

tanmay-j
Copy link
Contributor

@tanmay-j tanmay-j commented Nov 6, 2024

This PR closes #1154

The changes in this PR are as follows:

  • Add Route Table property support to Subnet Resource.

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let myRt = routeTable { name "my-rt" }
let myNet = vnet {
    name vnetName
    build_address_spaces [
        addressSpace {
            space "10.28.0.0/16"

            subnets [
                subnetSpec {
                    name "webSubnet"
                    size 24
                    route_table myRt
                }
            ]
        }
    ]
}

Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for including tests and doc updates.

@ninjarobot ninjarobot added this to the 1.9.5 milestone Nov 8, 2024
@ninjarobot ninjarobot merged commit c8c0892 into CompositionalIT:master Nov 8, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
Added route table support for subnets c8c0892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support to add Route Table in the Subnet builder
2 participants