Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer az structure. #1142

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Update to newer az structure. #1142

merged 3 commits into from
Oct 26, 2024

Conversation

isaacabraham
Copy link
Member

This PR closes #1141

The changes in this PR are as follows:

  • Use updated JSON structure for AZ.
  • Refactor code a little (readability)

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

  • No tests - end-to-end feature.

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let users = AccessPolicy.findUsers [ "[email protected]" ]
let groups = AccessPolicy.findGroups [ "a-group-in-entra" ]


$"\"{query}\""

static let handleSearchResponse =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a test of what the expected output would be given some JSON from a search response?

@isaacabraham isaacabraham merged commit cc02ad0 into master Oct 26, 2024
3 checks passed
@isaacabraham isaacabraham deleted the fix-1141 branch October 26, 2024 18:01
@ninjarobot ninjarobot added this to the 1.9.3 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectID breaking change in az ad commands
2 participants