CTest Fixes #9962
Merged
CTest Fixes #9962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 382dab0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.8% (0.0% change). View more on Code Climate. |
ggbecker
reviewed
Dec 13, 2022
| @@ -160,7 +160,7 @@ if (PY_MYPY) | |||
| ) | |||
| endif() | |||
|
|
|||
| if (PY_OPENPYXL AND PY_PANDAS AND PYTHON3_EXECUTABLE) | |||
| if (PYTHON_VERSION_MAJOR GREATER 2 AND PY_OPENPYXL AND PY_PANDAS AND SRG_PRODUCT_RHEL9) | |||
There was a problem hiding this comment.
isn't it SSG_PRODUCT_RHEL9 instead of SRG...?
There was a problem hiding this comment.
great, thanks for finding this, it should be SSG_PRODUCT_RHEL9
@Mab879 PTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a couple of issues with the CTest test suite.
Rationale:
Review Hints:
rhel9.